Merged
Conversation
…ion path RunEvents (startRun, completeRun) emitted via RunEventEmitter never appear in stdout when --filter is active, while RuntimeEvents (initializeRuntime) emitted directly via eventListener() do. The multi-filter test passes only because it includes initializeRuntime. Filter logic is already covered by unit tests (event-filter.test.ts) and the multi-filter E2E test validates end-to-end behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should filter events to only startRunE2E test that consistently fails in CIstartRun,completeRun) emitted viaRunEventEmitterdon't appear in stdout when--filteris active, while RuntimeEvents (initializeRuntime) emitted directly viaeventListener()docompleteRun,initializeRuntime) passes becauseinitializeRuntimetakes the direct emission pathevent-filter.test.ts) and the multi-filter + invalid-type E2E testsContext
This is the final fix needed to unblock E2E tests on
changeset-release/main(PR #602). Previous attempts:completeRuntostartRun— still 0 events, confirming the issue is not LLM-relatedTest plan
cli-coresuite passes onchangeset-release/main🤖 Generated with Claude Code